search

kabisa / maji

Maji is a framework to build great hybrid mobile apps.
https://www.majimobile.com/
MIT License
18 stars 10 forks source link

Test a fresh project on CI as well #238

Closed ariejan closed 5 years ago

ariejan commented 5 years ago

IMHO we should add a test (to bin/ci?) that creates a blank Maji app and runs the test on the generated app. This ensures that new users generate an app with passing tests.

I created this issue based on #237.

pascalw commented 5 years ago

@ariejan we actually have this already :-)

There is one issue though; the dependencies of the project we generate are not completely locked. We don't use exact versions in the package.json, nor include a yarn.lock. I think this is fine, because you then always get the latest minor versions of all dependencies, BUT it does mean that the generated project can break when dependencies change.

To prevent this, we could run the test suite nightly. I'll make that change.

ariejan commented 5 years ago

@pascalw awesome, thanks!

pascalw commented 5 years ago

Nightly build configured.