search

kabisa / maji

Maji is a framework to build great hybrid mobile apps.
https://www.majimobile.com/
MIT License
18 stars 10 forks source link

Preact-router does not have to be a peer dependency anymore #259

Closed ljpengelen closed 5 years ago

ljpengelen commented 5 years ago

Preact-router is listed as a peer dependency of Maji in package.json and as an external in the Rollup configuration. I think that's no longer needed. You can use Maji without preact-router if you want, so it's not necessary to trigger a warning when it's not installed.

pascalw commented 5 years ago

You're right. https://github.com/kabisa/maji/blob/e43d33367b1fe50afaad31649edf7bbd2eeffa97/src/pageTransitionSupport.js is a HOC now, so there's no compile dependency on preact-router.