kabisa / maji

Maji is a framework to build great hybrid mobile apps.
https://www.majimobile.com/
MIT License
18 stars 10 forks source link

Is 'supported-browsers' code actually needed? #262

Closed bazzel closed 5 years ago

bazzel commented 5 years ago

When generating a new Maji project, some setup is done for which browsers are supported using https://github.com/browserslist/browserslist. But according to its documentation the browserslist file (which will end up in the root of the generated Maji project) is found and interpreted automagically.

If so, this means that we don't need:

Although I can create a PR, I'm currently not sure how to verify if my assumptions are correct. Running npx browserslist after removing it from an existing project shows the same list of browsers.

pascalw commented 5 years ago

Hi @bazzel I think your observations are correct. This stems from a time were the browserslist file was not yet picked up automatically by Babel.

I think the best way to verify this is to: