search

kabisa / theguild.nl

https://theguild.nl
3 stars 0 forks source link

Use rouges class for gutter style #96

Closed Tuxified closed 6 years ago

Tuxified commented 6 years ago

Fixes #95, as the gutter element has .gl and .rouge-gutter class. Perhaps it was different before? 🤷‍♀️

thnukid commented 6 years ago

LGTM!

pascalw commented 6 years ago

Nice!

One small nitpick; there's no padding on the code itself now, which doesn't look that great IMO:

screen shot 2018-09-27 at 14 34 40

With 0.5em padding I think it looks much better:

screen shot 2018-09-27 at 14 35 50

Maybe you can make that change while you're at it? Or I can make the change on another PR if you want, let me know!

Tuxified commented 6 years ago

@pascalw done, there was obviously a css rule with different class. I didn't dare to change the rule to ems, as I don't know how it affects previous posts