search

kablamo / VimDebug

Integrate your debugger with Vim. Currently supports Perl, Python, and Ruby. This code is very much in beta.
37 stars 7 forks source link

Extract file name from Perl code ref debugger output. #4

Closed lucs closed 13 years ago

lucs commented 13 years ago

This patch allows the file name to be properly extracted from strings like this one:

App::Cpan::CODE(0xa3fd670)(/opt/apps/perl/lib/5.12.2/App/Cpan.pm:459):
kablamo commented 13 years ago

I just noticed this bug and it looks like you already fixed it. Nice! I'll take a look at this.

kablamo commented 13 years ago

Uh oh, your patch is gone. The codeRefBug branch is code from your fork of VimDebug. I'm not sure why.

kablamo commented 13 years ago

This is mostly a note to myself. Cuz I gotta run off to have dinner nowSo my problem is I can't do this 'git pull https://github.com/lucs/VimDebug.git codeRefBug'. It looks like you deleted that branch and a few others. But somehow I can still see your patch on GitHub website when I look at my pull requests. So I was thinking its an older version of your fork, but I don't see it in the commit history of your fork.

Anyway, I cut and pasted your changes from the browser into my code. It works great. I found an edge case it doesn't address, but its still covers more edge cases than my original code. :)

Edge case: Class::MOP::Method::Generated::CODE(0xa1e4988)(accessor amount defined at lib/Currency.pm:8):

lucs commented 13 years ago

D'oh! My mistake I suppose. What happened is I did delete the branch from my clone on github. Since your master had been updated, I thought that my branch (and others I had prepared) needed to be rebased -- which I did in my copy at home, but not on github, yet, so I just deleted the branches on github. I thought having the reference in the pull request was ok, but it seems that that is not quite correct. Well, there's a github beginner for you :/

Anyway, for what it's worth, I will attempt to fix the edge case you found, and reupload the branch again (rebased on the current master).

Sorry for the inconvenience.

kablamo commented 13 years ago

Fast! I merged this request. There are still a bunch of problems that come up when debugging stuff that uses Moose / Class::MOP, but this is an improvement.