search

kablamo / p5-shell-carapace

Log shell command output to a file and tee output to the screen ala cpanm
Other
0 stars 0 forks source link

please consider using Log::Any #3

Open jonassmedegaard opened 9 years ago

jonassmedegaard commented 9 years ago

Shell::Carapace looks like a nice module for my Boxer tool. But your module seems to hardcode a certain log handling, which is a shame - I have different opinions on how the log data should be stored, and may also extend my tool to be not only a CLI tool but also a web app where different logging is more suitable.

Please consider using Log::Any, to allow each consumer to decide how log info is handled.

...and if parts of this project is to implement a very specific way of handling log data, then consider splitting that into a Log::Any::Adapter subclass.

kablamo commented 9 years ago

Thanks for the interest! I have been wanting to use Log::Any as well. I think I agree with everything you said. Thats the main reason I haven't tried to promote this tool yet. I'l take a look at Boxer.

jonassmedegaard commented 9 years ago

Quoting Eric Johnson (2015-04-01 16:00:44)

Thanks for the interest! I have been wanting to use Log::Any as well. I think I agree with everything you said. Thats the main reason I haven't tried to promote this tool yet.

Cool!

I'l take a look at Boxer.

Thanks for the curiosity. Don't expect elegant use of Log::Any there, however, as I only recently looked into proper logging: The code on CPAN has no working logging at all - I just pushed some fixes to the git.

Also, Boxer currently usable only for Debian. Ideally shouldn't be, but it is still in its infancy - as am I as a CPAN contributor - any and all criticism is highly appreciated :-)