search

kaboomserver / server

Server files for the Kaboom server
The Unlicense
19 stars 31 forks source link

Don't hide vanished users, but give the invisibily effect instead #100

Closed ChipmunkMC closed 1 year ago

ChipmunkMC commented 1 year ago

This is a temporary fix to 1.19.3 clients disconnecting with Chat message validation failure when a vanished user chats. The cause is the client not being able to find the player who sent the message in the player list. While it is likely possible to not send other clients their player entity while keeping them in the player list, I am not sure if Essentials supports such behavior.

ChipmunkMC commented 1 year ago

This might actually not be an issue anymore after 993fda79b96f5525fb740b8aabf0dea6622e271c, after which chat seems to behave differently. Vanish is probably worse this way anyway, and this was meant to be a temporary fix, which I mainly just made since the issue could be abused to make clients disconnect, so feel free to close this.

ghost commented 1 year ago

This might actually not be an issue anymore after 993fda7, after which chat seems to behave differently. Vanish is probably worse this way anyway, and this was meant to be a temporary fix, which I mainly just made since the issue could be abused to make clients disconnect, so feel free to close this.

This was fixed by https://github.com/AtlasMediaGroup/Scissors/commit/1dddffad0d8748ad5f63fa655cc19d6a429ef454, in which the option to disable chat signatures was added back (1.19.3 broke the original patch, and it was required to fully re-write the signature disabling in the first place).

It should be noted that Notchian 1.19.3 clients would also be disconnected with Chat message validation failure if an offline client sent a chat message (without a signature of course).

Pull request closed as it fixed an issue that is no longer prevalent.

Feel free to re-open the pull request if needed.