search

kaboomserver / server

Server files for the Kaboom server
The Unlicense
19 stars 27 forks source link

Remove the command block update ratelimit #129

Closed ChipmunkMC closed 3 weeks ago

ChipmunkMC commented 1 month ago

As you may know, #110 added a command block ratelimit. Although this prevents spam, it has also caused problems with:

These are things I enjoy the freedom of being able to do, and the core ratelimit makes them hard to impossible. If this is merged, the server will be more fun to play on in my opinion. Many clones have already removed the ratelimit, anyway.

yfdmc commented 1 month ago

The core ratelimit is very annoying for many players as they may want to do things they cannot because of the core ratelimit (things states above) and I have been a victim many times! I have tried to play music with /playsound many times and lots of complex songs get ruined by the core ratelimit. If this was voting for stuff, I would vote for core ratelimit to be removed.

kaboombot commented 1 month ago

Can the limit be bumped to a point where it doesn't cause issues for legitimate use cases, but still prevents spam? I don't know what minimum limit people need.

Dinhero21 commented 1 month ago

Can the limit be bumped to a point where it doesn't cause issues for legitimate use cases, but still prevents spam? I don't know what minimum limit people need.

Because of jitter, the limit would need to be so high that it would be ineffective against command block spam.

Dinhero21 commented 1 month ago

As you may know, #110 added a command block ratelimit. Although this prevents spam, it has also caused problems with:

  • Playing certain songs (via playsound)
  • Rendering images
  • Building structures (with setblock and fill)
  • Possibly more

These are things I enjoy the freedom of being able to do, and the core ratelimit makes them hard to impossible. If this is merged, the server will be more fun to play on in my opinion. Many clones have already removed the ratelimit, anyway.

A possible solution would be to keep the limit only for impulse and repeating command blocks. Then, to play music, you could /fill a big area with chain command blocks, update_command_block them and activate a single impulse/repeating command block at the start.

(tbh kinda scuffed, I would prefer if the limit was just removed)

ZenZoyaUDR commented 1 month ago

Bump!

kaboombot commented 3 weeks ago

Honestly, I don't really care. If this happens to break the server, you'll have to live with it.

Dinhero21 commented 3 weeks ago

Why was it added in the first place?

If its to stop lag, there are many better ways of doing it by using other packets, spamming connections, exploits, etc.

Dinhero21 commented 3 weeks ago

A better way of handling packet capping might be to queue them so that instead of dropping you just delay them.

Doesn't seem to be supported by Paper out of the box though