search

kabouzeid / Phonograph

A material designed music player for Android
GNU General Public License v3.0
2.73k stars 728 forks source link

Sort by "album sort order" tag #140

Open sersorrel opened 7 years ago

sersorrel commented 7 years ago

It seems that there's an MP3 tag for album sort order (ID3v2.4 TSOA) that, according to someone on reddit, Phonograph doesn't respect. Specifically, the usecase was for playing an artist's albums in order of release (if the sort order tag has the year of release at the start, e.g. "1982 Thriller", "1979 Off the Wall"). If this isn't already supported, is there any chance it could be? How hard would it be for a novice Android programmer to implement?

theduffster commented 7 years ago

This is definitely interesting, it would be as simple as an if statement I think. Once I finish some other things I'll get on it. Relevant info if anyone wants to try implementing it first: http://id3.org/id3v2.4.0-frames

rmetcalf9 commented 7 years ago

Phonograph is the thrid music player I have downloaded which doesn't do this. I am trying to find a music player that does do it. I was considering if a sort order option for album music was needed but I don't think it ever makes sense to display album tracks in any order other than the order they appear on the album.

theduffster commented 7 years ago

@rmetcalf Agreed. Looks like there's a number of sort order tags. The logical thing to do would be to check for any of these tags when sorting before checking for other tags.

atriede commented 7 years ago

I would love to have the option when viewing by album to sort by artist, artist/year, and year.

rmetcalf9 commented 7 years ago

Yes but it needs to be an option. The default should be by album order

On 3 Oct 2017 04:33, "atriede" notifications@github.com wrote:

I would love to have the option when viewing by album to sort by artist, artist/year, and year.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/kabouzeid/Phonograph/issues/140#issuecomment-333729266, or mute the thread https://github.com/notifications/unsubscribe-auth/ANlprlOzNh9-DHgyfm-x1qrfL7L3luupks5soasUgaJpZM4NFKva .