kabouzeid / Phonograph

A material designed music player for Android
GNU General Public License v3.0
2.73k stars 728 forks source link

Scrolling Album Art View #308

Open ghost opened 7 years ago

ghost commented 7 years ago

Reaching the top and bottom of the album art view via scrolling no longer shows the android rubber band effect, making the app look less professional

-

Device info:

App version0.16.0
App version code140
Android build version75221db857
Android release version7.1.2
Android SDK version25
Android build IDlineage_athene-userdebug 7.1.2 NJH47F 75221db857 release-keys
Device brandMotorola
Device manufacturerMotorola
Device nameathene
Device modelMoto G4
Device product namelineage_athene
Device hardware nameqcom
ABIs[armeabi-v7a, armeabi]
ABIs (32bit)[armeabi-v7a, armeabi]
ABIs (64bit)[]
arkon commented 7 years ago

I'm still seeing it. Does this happen for all albums? Do you have a screenshot?

ghost commented 7 years ago

This bug doesn't happen within the view of an actual specific album, it happens in the album tab when you scroll to the top or bottom (the view where you can see the album arts of all your albums).

I can't really take a screenshot as it won't show you anything useful, the animation doesn't happen whereas it did before. Thanks for your time!

arkon commented 7 years ago

I asked about the album because it might be hard to see it against lighter backgrounds. It's actually hard to see it at the bottom of a list with the light theme, but easier to see when using the dark theme.

kabouzeid commented 7 years ago

can confirm, doesn't show the edge glow for me too (light and dark theme)

arkon commented 7 years ago

Ah, I misread. You're right, it's missing from the tabs view.

GeoZac commented 6 years ago

Does RecyclerView-FastScroll have support for overscroll? I tried to set overscroll but seems to have no effect and I did a quick check on the source too?