kabouzeid / Phonograph

A material designed music player for Android
GNU General Public License v3.0
2.73k stars 729 forks source link

Album tracklist queue and Interface #357

Open DeusArcana opened 7 years ago

DeusArcana commented 7 years ago

Hello, I have two issues with Phonograph.

  1. The first one is about random playing queue: if you want to play an entire album in tracklist order, you only have to play the first song in the album, but this isn't seem to be working, every time that I do this the queue is random.

  2. The second one is just a sugerence: it could be possible to disappear those icons in the superior part of the screen (I don't know how are called), this could be done when you make tap to see the album cover. (Maybe this happens because of my phone, I don't know)

img_20171115_192530_710

I love the LRC incorporation and I want to know how it works the Synced Translations. Thanks beforehand.

arkon commented 7 years ago
  1. You can just toggle shuffle mode again and it'll play in order. This is definitely a UX issue that's come up before, and we'll address it somehow in the future.

  2. That might be possible as an enhancement, will need to see if it can happen smoothly.

You can check our #155, which is the PR that added the synced lyrics.

DeusArcana commented 7 years ago

Maybe I have a misunderstanding here. When we are tallking about 'Synced Translations', we aren't talking about lyrics?

img_20171119_113255_986

I was thinking on something like MusicXMatch.

GeoZac commented 7 years ago

The lyrics are fetched from *lrc file in same folder as the music file.Not from servers as in case of Musixmatch

On 20-Nov-2017 8:04 AM, "DeusArcana" notifications@github.com wrote:

Maybe I have a misunderstanding here. When we are tallking about 'Synced Translations', we aren't talking about lyrics?

[image: img_20171119_113255_986] https://user-images.githubusercontent.com/16895631/32999551-2cdbf59a-cd60-11e7-985f-ced28fc62642.JPG

I was thinking on something like MusicXMatch.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/kabouzeid/Phonograph/issues/357#issuecomment-345576066, or mute the thread https://github.com/notifications/unsubscribe-auth/ALD1TuM3MYXzfQFmqfcnXHTg5xmmesUAks5s4OVMgaJpZM4Qf4Zs .

arkon commented 7 years ago

Oh, I didn't realize that's what you were talking about. That's just referring to the app translations: https://phonograph.oneskyapp.com/collaboration/project?id=26521

DeusArcana commented 7 years ago

I see, thanks for the information. Parece que el idioma español está cubierto, no necesitan más aportaciones. :P

I mentioned MusixMatch because of his feature about translated and transliterated lyrics, I thought something like that was implemented with Phonograph with changes to LRC format or some ingenious thing.