kabouzeid / Phonograph

A material designed music player for Android
GNU General Public License v3.0
2.73k stars 728 forks source link

Song ordering within an album #824

Open biner1999 opened 4 years ago

biner1999 commented 4 years ago

Quite recently I seen that 8th and 9th songs on a lot of albums are not in order. The songs are tagged correctly but the songs with tags 8 and 9 show up at the top of the album, out of order.

-

Device info:

App version1.3.3
App version code177
Android build version2004142132
Android release version10
Android SDK version29
Android build IDONEPLUS A6003_22_200414
Device brandOnePlus
Device manufacturerOnePlus
Device nameOnePlus6
Device modelONEPLUS A6003
Device product nameOnePlus6
Device hardware nameqcom
ABIs[arm64-v8a, armeabi-v7a, armeabi]
ABIs (32bit)[armeabi-v7a, armeabi]
ABIs (64bit)[arm64-v8a]
marcelscode commented 4 years ago

I can confirm this. However, it seems to be an Android thing, not a Phonograph bug. It is present not only in Phonograph, but also in other music players (e.g. Pulsar).

alstolten commented 4 years ago

I also can confirm this.

I tried Pulsar, but there it seems fixed, albums begin correctly with track number 1.

marcelscode commented 4 years ago

This seems to happen when the track number is not just, e.g., 1 but 1/10. It is gone for me after having just digits in the track field and using ID3v2.3 (I did not try ID3v2.4).

alstolten commented 4 years ago

Hmm, for me it seems like it happens for every tag which has 08 or 09 as track number, but not for 01 to 07 and also not for 8 and 9.

stepanmracek commented 4 years ago

Yes, it is issue when track number is starting with zero. I think that it is caused by automatic conversion of strings "08" and "09" to integers. When it starts with "0" Android/Phonograph is trying to parse them as octals. "08" and "09" are invalid octal values. I also tried to set track numbers to "010" and "011" and as I expected - they were displayed in Phonograph as tracks 8 and 9.