search

kabouzeid / phonograph-issue-tracker

14 stars 0 forks source link

Issue Rendering Cover Artwork #164

Open uxcn opened 8 years ago

uxcn commented 8 years ago

I'm seeing issues with cover artwork being rendered. I generally have embedded artwork in the music, but the cover images don't render in the album list (other places). Oddly enough, they do render in Tag editor though.

The one correlation I could see was files having more than one image embedded in them.

For example...

jason@io repository ogginfo ogg/Aphex\ Twin/Drukqs/1-01\ Jynweythek.ogg
Processing file "ogg/Aphex Twin/Drukqs/1-01 Jynweythek.ogg"...

New logical stream (#1, serial: 000065e2): type vorbis
Vorbis headers parsed for stream 1, information follows...
Version: 0
Vendor: Xiph.Org libVorbis I 20050304 (1.1.1)
Channels: 2
Rate: 44100

Nominal bitrate: 192.000000 kb/s
Upper bitrate: 4294967.295000 kb/s
Lower bitrate: 4294967.295000 kb/s
User comments section follows...
  TITLE=Jynweythek
  RELEASECOUNTRY=US
  TOTALDISCS=2
  LABEL=Sire Records
  TOTALTRACKS=15
  MUSICBRAINZ_ALBUMARTISTID=f22942a1-6f70-4f48-866e-238cb2308fbd
  DATE=2001-10-23
  DISCNUMBER=1
  TRACKTOTAL=15
  MUSICBRAINZ_RELEASETRACKID=ca479928-bb0a-3b54-a7c6-188b0cd37871
  ASIN=B00005QD9N
  ALBUMARTISTSORT=Aphex Twin
  ORIGINALDATE=2001-08
  SCRIPT=Latn
  MUSICBRAINZ_ALBUMID=a3a96dde-8af3-3622-a936-4ac3af501e1d
  RELEASESTATUS=official
  ALBUMARTIST=Aphex Twin
  CATALOGNUMBER=31174-2
  ALBUM=Drukqs
  MUSICBRAINZ_ARTISTID=f22942a1-6f70-4f48-866e-238cb2308fbd
  MEDIA=CD
  RELEASETYPE=album
  ORIGINALYEAR=2001
  ISRC=GBBPW0100134
  MUSICBRAINZ_RELEASEGROUPID=87f1a316-510f-36c3-9f2c-38230b0e56e0
  DISCTOTAL=2
  ARTIST=Aphex Twin
  BARCODE=643443117425
  MUSICBRAINZ_TRACKID=293ea1b0-9ce4-44af-a46e-ad699975ba74
  ARTISTSORT=Aphex Twin
  ARTISTS=Aphex Twin
  TRACKNUMBER=1
  METADATA_BLOCK_PICTURE=AAAAAwAAAAppbWFnZS9qcGVnAAAAAAAAAAAAAAAAAAAAAAAAAAAAA...
  METADATA_BLOCK_PICTURE=AAAABAAAAAppbWFnZS9qcGVnAAAAAAAAAAAAAAAAAAAAAAAAAAAAY...
Vorbis stream 1:
  Total data length: 3284821 bytes
  Playback length: 2m:23.361s
  Average bitrate: 183.303381 kb/s
Logical stream 1 ended
WARNING: Hole in data (2088 bytes) found at approximate offset 12087000 bytes. Corrupted Ogg.
WARNING: Hole in data (1694 bytes) found at approximate offset 12088694 bytes. Corrupted Ogg.

and...

jason@io repository ogginfo ogg/Tool/Ænima/01\ Stinkfist.ogg
Processing file "ogg/Tool/Ænima/01 Stinkfist.ogg"...

New logical stream (#1, serial: 6536c325): type vorbis
Vorbis headers parsed for stream 1, information follows...
Version: 0
Vendor: Xiph.Org libVorbis I 20150105 (⛄⛄⛄⛄)
Channels: 2
Rate: 44100

Nominal bitrate: 160.000000 kb/s
Upper bitrate not set
Lower bitrate not set
User comments section follows...
    PRODUCER=David Bottrill
    PRODUCER=Tool
    TITLE=Stinkfist
    RELEASECOUNTRY=US
    TOTALDISCS=1
    LABEL=Volcano Records
    TOTALTRACKS=15
    MUSICBRAINZ_ALBUMARTISTID=66fc5bf8-daa4-4241-b378-9bc9077939d2
    DATE=1996-10-01
    DISCNUMBER=1
    TRACKTOTAL=15
    MUSICBRAINZ_RELEASETRACKID=7e731029-c851-3e8d-bbf4-bffb4a625f70
    ALBUMARTISTSORT=Tool
    ORIGINALDATE=1996-09-17
    SCRIPT=Latn
    MUSICBRAINZ_ALBUMID=b1b9bf98-86fa-4092-950f-1fb6744a25b4
    RELEASESTATUS=official
    ALBUMARTIST=Tool
    ACOUSTID_ID=8662b220-dc6b-4e04-8bcd-8449efb1136c
    CATALOGNUMBER=61422-31087-2
    ENGINEER=David Bottrill
    ALBUM=Ænima
    MUSICBRAINZ_ARTISTID=66fc5bf8-daa4-4241-b378-9bc9077939d2
    MEDIA=CD
    RELEASETYPE=album
    MIXER=David Bottrill
    ORIGINALYEAR=1996
    ISRC=USZE19600081
    MUSICBRAINZ_RELEASEGROUPID=ef1e8130-dd5f-336a-85fa-4936a47342bd
    DISCTOTAL=1
    ARTIST=Tool
    BARCODE=614223108728
    MUSICBRAINZ_TRACKID=827cf397-a290-4a0b-b1d3-3cd5100fccfa
    ARTISTSORT=Tool
    ARTISTS=Tool
    TRACKNUMBER=1
    METADATA_BLOCK_PICTURE=AAAAAwAAAAlpbWFnZS9wbmcAAAAAAAAAAAAAAAAAAAAAAAAAAAA...
    METADATA_BLOCK_PICTURE=AAAABAAAAAppbWFnZS9qcGVnAAAAAAAAAAAAAAAAAAAAAAAAAAA...
    METADATA_BLOCK_PICTURE=AAAABgAAAAppbWFnZS9qcGVnAAAAAAAAAAAAAAAAAAAAAAAAAAA...
    METADATA_BLOCK_PICTURE=AAAABQAAAAppbWFnZS9qcGVnAAAAAAAAAAAAAAAAAAAAAAAAAAA...
    METADATA_BLOCK_PICTURE=AAAABQAAAAppbWFnZS9qcGVnAAAAAAAAAAAAAAAAAAAAAAAAAAA...
    METADATA_BLOCK_PICTURE=AAAABQAAAAppbWFnZS9qcGVnAAAAAAAAAAAAAAAAAAAAAAAAAAA...
    METADATA_BLOCK_PICTURE=AAAABQAAAAppbWFnZS9qcGVnAAAAAAAAAAAAAAAAAAAAAAAAAAA...
    METADATA_BLOCK_PICTURE=AAAABQAAAAppbWFnZS9qcGVnAAAAAAAAAAAAAAAAAAAAAAAAAAA...
    METADATA_BLOCK_PICTURE=AAAABQAAAAppbWFnZS9qcGVnAAAAAAAAAAAAAAAAAAAAAAAAAAA...
    METADATA_BLOCK_PICTURE=AAAABQAAAAppbWFnZS9qcGVnAAAAAAAAAAAAAAAAAAAAAAAAAAA...
    METADATA_BLOCK_PICTURE=AAAAAAAAAAppbWFnZS9qcGVnAAAAAAAAAAAAAAAAAAAAAAAAAAA...
Vorbis stream 1:
    Total data length: 5917507 bytes
    Playback length: 5m:11.093s
    Average bitrate: 152.173161 kb/s
Logical stream 1 ended

Device info:

App version0.13.3
App version code120
Android build version3239497
Android release version7.0
Android SDK version24
Android build IDNBD90W
Device brandgoogle
Device manufacturerLGE
Device namebullhead
Device modelNexus 5X
Device product namebullhead
Device hardware namebullhead
ABIs[arm64-v8a, armeabi-v7a, armeabi]
ABIs (32bit)[armeabi-v7a, armeabi]
ABIs (64bit)[arm64-v8a]

If there's anything I can help with, don't hesitate to let me know.

arkon commented 7 years ago

Did you ever try removing some of the extra album art and seeing if it would show up if there's only one embedded?

uxcn commented 7 years ago

@arkon Can the code handle more than one album art tag? If I remember correctly, album tiles will render if all of the album art, except one tag, is removed from the album files.

arkon commented 7 years ago

@uxcn I haven't dived into the code deep enough yet to really answer that confidently, but I do know that it just gets the album art corresponding to the first track. I don't think it correctly handles more than one album art tag right now.