search

kabuspl / to-google-lens

Firefox extension.
MIT License
7 stars 3 forks source link

Cannot send anything to google lens Infinite spinner. Also the selection curor is invisible on some sites. #6

Closed mzso closed 9 months ago

mzso commented 1 year ago

I guess the mean functionality plainly just broke, probably by a change from google. Never goes beyond the "Uploading image..." message.

Also selection can be rather annoying because, the cursor becomes invisible. Perplexingly on pages with white backgrounds, which is the most common appearance... Random example: https://floravita.superwebaruhaz.hu/

kabuspl commented 1 year ago

Fixed. I didn't notice the invisible cursor on white backgrounds because I use dark mode. Thanks for the report!

mzso commented 1 year ago

@kabuspl commented on Sep 28, 2023, 4:34 PM GMT+2:

Fixed. I didn't notice the invisible cursor on white backgrounds because I use dark mode. Thanks for the report!

Originally posted by @kabuspl in https://github.com/kabuspl/to-google-lens/issues/6#issuecomment-1739381173

Great. I can verify that it works now.

I wonder what you mean by dark mode though? My OS and FF instance does use dark theme as well. But light webpages are light of course.

mzso commented 1 year ago

However I observe some submissings getting stuck uploading. Potentially infinitely. This submission (I don't know if it appears appropriately) got stock for a minute or so (with an almost itentical submission) until a I searched for a smaller image. Trying it a third time it got stock forever apparently. For the third time it got stuck for several minutes. 4-7 minutes, until I almost got finished typing this comment. I tried refreshing a couple times during the wait, but it had no effect.

It's a mere screenshot of this video.

kabuspl commented 1 year ago

@kabuspl commented on Sep 28, 2023, 4:34 PM GMT+2:

Fixed. I didn't notice the invisible cursor on white backgrounds because I use dark mode. Thanks for the report! Originally posted by @kabuspl in #6 (comment)

Great. I can verify that it works now.

I wonder what you mean by dark mode though? My OS and FF instance does use dark theme as well. But light webpages are light of course.

I have DarkReader extension that turns all light websites dark.

kabuspl commented 1 year ago

However I observe some submissings getting stuck uploading. Potentially infinitely. This submission (I don't know if it appears appropriately) got stock for a minute or so (with an almost itentical submission) until a I searched for a smaller image. ~Trying it a third time it got stock forever apparently.~ For the third time it got stuck for several minutes. 4-7 minutes, until I almost got finished typing this comment. I tried refreshing a couple times during the wait, but it had no effect.

It's a mere screenshot of this video.

I will take a look at it. I was able to reproduce it.

mzso commented 9 months ago

This is still very common. Often it gets stuck on loading. Sometimes it gets unstuck if I search for another screenshot. And both are sent simultaneously. (usually about the same thing)

kabuspl commented 9 months ago

I found a way to fix this. For some reason, Google's server sometimes has a problem with PNG files sent by this extension. I changed the code to send WEBP files instead and now it always works.