kaceycsn / pe

0 stars 0 forks source link

Add allergen does not work for some ingredients #8

Open kaceycsn opened 1 year ago

kaceycsn commented 1 year ago

Unable to add certain ingredients as allergen. Not sure if there is a list of pre-defined allergens that users have to follow, but cant seem to find it any where in the user guide

image.png

nus-pe-bot commented 1 year ago

Team's Response

This ingredient is not considered a valid ingredient in our program as of version 2.1.

It is clearly stated in the user guide what the user can do to see a list of ingredients considered as valid in our program, as such the error message is easily interpretable by the users.

Since the ingredient is not a valid ingredient in our program yet, there are also no recipes that would include these ingredients, hence it would also be unnecessary to add that ingredient and this would not affect the usage of our program.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: The team's response does not adequately address the issue. The response of the team is that the add allergen function correctly fails as the allergen being input does not cohere to the pre-defined list. This does not address the issue that the list of pre-defined allergens is not printed any where during the run of the programme, neither is it specifically listed out in the user guide.

According to the team's response, it is "stated in the user guide what the user can do to see a list of ingredients considered as valid in our program". However, users may not infer that the pre-defined allergens are the same as the pre-defined recipe ingredients. Furthermore in the add allergen section of the user guide, there is also no portion that clearly instructs users on how to view the list of pre-defined allergens. Hence, it is an unreasonable assumption that users will know how to access the list of pre-defined allergens. This causes much confusion to the users. Additionally, as reported by another report issue, the ingredients search command fails. This makes it impossible to access the pre-defined ingredients/allergens list.

Without knowledge of the pre-defined allergens list, the add allergen function becomes unusable.

image.png