search

kach / nearley

📜🔜🌲 Simple, fast, powerful parser toolkit for JavaScript.
https://nearley.js.org
MIT License
3.59k stars 232 forks source link

whitespace: add \r (windows EOL) to chars #606

Open msimerson opened 2 years ago

msimerson commented 2 years ago

I've written a parser using builtins/whitespace and the Windows CI tests failed, because the EOL characters are \r instead of \n.

kach commented 2 years ago

Seems straightforward. Could you add a test for this, then I'll merge it?

msimerson commented 2 years ago

The test is only going to work correctly on Windows, and a bunch more code changes are required in this repo before windows CI tests pass. I started down that road and its a slog.

msimerson commented 2 years ago

related to #581

msimerson commented 2 years ago

likely also related to #522

msimerson commented 2 years ago

and related to #474