Fixed my issue with batch processing

kachkaev / php-r

Provides ability to run R scripts from PHP

MIT License

144 stars 41 forks source link

Fixed my issue with batch processing #19

Closed yooper closed 9 years ago

kachkaev commented 9 years ago

Hi @yooper,

Thanks for the PR! Which OS are you using?

I don't quite remember why there wasn't that extra line for pipes[1] initially. It could be that it made things in OSX worse. According to you knowledge, may your change cause any problems in any OS?

I'll be happy to merge the PR, just want to make sure the fix is cross-platform. I don't have an opportunity to test the library well.

yooper commented 9 years ago

I do not have a OSX system to test on and according to the documentation, http://php.net/manual/en/function.stream-set-blocking.php#110997 , set_stream_blocking does not work on windows in when the pipe is opened by proc_open. Do you have an OSX system?

kachkaev commented 9 years ago

Yes, I do.

yooper commented 9 years ago

I am closing this PR. I opted to use R's existing batch functionality.