kachkaev / php-r

Provides ability to run R scripts from PHP

MIT License

144 stars 41 forks source link

Invalid psr-4 namespacing #27

Closed ghola closed 7 years ago

ghola commented 7 years ago

Fixes #25 and pretty much fixes the library for anyone that wants to use it. Latest master is unusable without this fix, regardless of PHP version.

kachkaev commented 7 years ago

Hi @ghola, thanks for the PR!

I was not using php-r for a while, so can't easily check the fix. PSR-4 was introduced in #24, which could cause a bit of a mess I assume. Shall I just merge your PR? Do you think this would be safe?

ghola commented 7 years ago

Hey @kachkaev!

24 is what introduced the bug. It fixed an issue regarding PHP7 by eliminating php 5.* version restriction but then it wrongfully altered the psr making it fail for everyone not only PHP7.

kachkaev commented 7 years ago

Got it, makes sense. Thanks again for your time on submitting this PR! If you'd like to improve php-r in any other way, I'm very open to suggestions!