EventController send notification method review

kachnitel / ridetime-server

RideTime app server

MIT License

2 stars 1 forks source link

Open kachnitel opened 4 years ago

kachnitel commented 4 years ago

Reduce duplication
sendNotification($event, User[] $exclude, $type, $subType)
- OR ($event->getConfirmedMembers()->filter(currentUser), $type, $subType)
- extracts tokens internally
- REVIEW: only get $type (both eventMember and eventJoinRequested subtype) and determine title and description from a "dictionary"
- Exclude can be Current user and potentially another affected user that receives a different message (join approved)

kachnitel commented 4 years ago

Possible to make more flexible? Ie to add notification when friend joins / creates a ride in fav. location