search

kachurovskiy / lathecode

Text format for lathe parts and other objects with circular symmetry
MIT License
12 stars 3 forks source link

[Bug] Local Storage issue #9

Closed Festivejelly closed 8 months ago

Festivejelly commented 8 months ago

At the moment when you click more under the lathe code to be able to save and load to local storage it will show anything in local storage in the list. This could include local storage from plugins and extensions etc.

To fix this I think maybe the names in local storage should be prefixed with latheCode_{name of save}

And when loading the page iterate only over those that has latheCode_ prefix.

kachurovskiy commented 8 months ago

Well, some folks already have stuff saved without the prefix. It would stop showing up if we do this now. We can filter and only show multi-line values.

Festivejelly commented 8 months ago

Could we maybe iterate over existing values to determine if they are lathe code, then “fix” the ones that are

kachurovskiy commented 8 months ago

Yeah, but then we'd have to keep that migration code around for some unknown period of time. Hope the issue is sufficiently mitigated :) Thanks!