visual diffs for PRs - Githubissues

kactus-io / kactus

:cactus: A true version control tool for designers

https://kactus.io

MIT License

1.5k stars 86 forks source link

visual diffs for PRs #11

Open mathieudutour opened 7 years ago

mathieudutour commented 7 years ago

because you can't see the diffs as images on GitHub, it would be nice to be able to see PR in kactus

Not sure how tho. One option:

3rd tab (next to "Changes" and "History") "Compare"
- you could select a branch to compare to
- find the PRs which contain this branch and have a select box with them (or maybe a UI more similar to the "history" tab, with a first column with the list of branches to compare to (and PRs) and a second column with the changed files)
- add a textarea to comment on a file

mathieudutour commented 7 years ago

maybe something like this: pr view

mathieudutour commented 7 years ago

later on, we could even select an area on the visual diff and add a comment (using the github API and a special format to specify the area). The comments could then be shown on the diff directly

pixelbandito commented 7 years ago

Would you consider (also) adding an option to screenshot artboards and/or components and commit them in a directory alongside the pages? Then you'd get visual diffs in Github. Might also be more straightforward than building a PR view into the tool.

mathieudutour commented 7 years ago

that's what I was doing with git-sketch-plugin but then you can't merge PRs, there are conflicts every time. So no, I don't think it's a nice solution, I prefer taking the time to do that correctly :)

asos-dylanslewis commented 6 years ago

Wouldn't this be better served by creating a Danger plugin that runs on CIs and posts a comment on the GitHub PR with before and after screenshots in a nice table? Would help with visibility to those who only have GitHub available.

mathieudutour commented 6 years ago

I think it's a bit orthogonal. It would sure be nice although it requires a macOS CI server (Travis provides one for free). It would also require storing the screenshots somewhere. This is all possible but non-trivial to solve in a general case.

And I don't think it would be as nice as having it in Kactus where you could see the changes at different level, comment on a specific file, etc.

asos-dylanslewis commented 6 years ago

This is all possible but non-trivial to solve in a general case.

Yeah, good point. I really wish the GitHub API allowed you to mimic dragging a file on a PR. So the best, private solution would be something like fastlane's cert tool, where it stores the images in a separate, private repository on GitHub. But as you say, this is non-trivial.

chriswiesner commented 5 years ago

any plans on that?

i have a related question. Merging a branch within kactus is not supported, right? So i'd need to merge using another git client and then go back to kactus to e.g. resolve merge conflicts, right?

mathieudutour commented 5 years ago

Merging a branch within kactus is not supported

It is, Branch > Merge into current branch

chriswiesner commented 5 years ago

Thanks, sorry I somehow didn't pay attention to the menu, and was looking in the branch selection "tile"