search

kactus-io / kactus

:cactus: A true version control tool for designers
https://kactus.io
MIT License
1.5k stars 86 forks source link

Generated Sketch file cannot generate valid folder structure. #98

Open synthresin opened 6 years ago

synthresin commented 6 years ago

Description

Folder > Sketch generation process works fine. Sketch > Folder export process makes invalid folder.

Version

Steps to Reproduce

  1. Generate Watcha 4.0 iOS Sketch file from Watcha 4.0 iOS folder. (It can be opened by Sketch without any issue.)
  2. remove Watcha 4.0 iOS folder
  3. regenerate folder from generated Watcha 4.0 iOS sketch file.
  4. find the folder broken (missing document.json)

Expected Behavior

Generated folder from the Sketch file shouldn't be broken.

Actual Behavior

It's broken.

Additional Information

I've shared the repo. the branch is report/20180503

Logs

2018-05-03.kactus.production.log

synthresin commented 6 years ago

Seems fine when I completely remove the folder from repository and commit, then regenerate new folder from the file(modified in Sketch 50).

synthresin commented 6 years ago

I'll report if I get similar error again even though I keep matching sketch version across the team.

But I think there should be some way to notify JSON side effect generated by sketch version upgrade in Kactus. I don't know if it can be solved from Kactus side alone.