kaczmarj / apptainer-in-docker

Apptainer in Docker!
Apache License 2.0
43 stars 9 forks source link

Update dockerhub image for Apptainer 1.3 #18

Open dmilkie opened 2 weeks ago

dmilkie commented 2 weeks ago

I'm trying to use Apptainer 1.3 so I can use build arguments in my Apptainer build.

However, the latest docker image released on DockerHub is 1.2.

I tried building docker image with the command here: https://github.com/kaczmarj/apptainer-in-docker?tab=readme-ov-file#build-image

but I'm getting this error:

--------------------
  20 |     WORKDIR $GOPATH/src/github.com/apptainer
  21 | >>> RUN git clone https://github.com/apptainer/apptainer.git \
  22 | >>>     && cd apptainer \
  23 | >>>     && git checkout "$APPTAINER_COMMITISH" \
  24 | >>>     && ./mconfig $MCONFIG_OPTIONS -p /usr/local/apptainer \
  25 | >>>     && cd builddir \
  26 | >>>     && make \
  27 | >>>     && make install
  28 |
--------------------
ERROR: failed to solve: process "/bin/sh -c git clone https://github.com/apptainer/apptainer.git     && cd apptainer     && git checkout \"$APPTAINER_COMMITISH\"     && ./mconfig $MCONFIG_OPTIONS -p /usr/local/apptainer     && cd builddir     && make     && make install" did not complete successfully: exit code: 1
kaczmarj commented 2 weeks ago

can you try updating the Dockerfile base image to

FROM golang:1.23.2-alpine3.20
dmilkie commented 2 weeks ago

Yes. that works. I changed to alphine3.20 in line 29 as well

kaczmarj commented 2 weeks ago

fantastic. would you like to submit a pull request with these changes?