Add definition protected=public for bindings

domi4484 commented 1 week ago

I still need this definition to be able to build. Can we re-add it? Or there is another fix?

/home/domi/dev/kadas/build/python/kadasanalysis/build/_kadasanalysis/sip_kadasanalysispart5.cpp: In function ‘PyObject* meth_KadasNineCellFilter_calcFirstDerY(PyObject*, PyObject*, PyObject*)’:
/home/domi/dev/kadas/build/python/kadasanalysis/build/_kadasanalysis/sip_kadasanalysispart5.cpp:833:43: error: ‘float KadasNineCellFilter::calcFirstDerY(float*, float*, float*, float*, float*, float*, float*, float*, float*)’ is protected within this context
  833 |             sipRes = sipCpp->calcFirstDerY(&a0, &a1, &a2, &a3, &a4, &a5, &a6, &a7, &a8);
      |                      ~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

domi4484 commented 1 week ago

But MSVC doesn't seems happy about that... @m-kuhn do you have an easy idea? If its something complex I can just keep the local modification on my side...

m-kuhn commented 1 week ago

@domi4484 what happens if you add it more specific like here: https://github.com/kadas-albireo/kadas-albireo2/pull/112/files#diff-42a7083fe720c28474f5aa0dc9a4eef980b9a28cfc634300a3322b9d21fbdb49R133 ?

m-kuhn commented 1 week ago

In case it still does not work, just wrap it into a if(NOT MSVC) and it should be good.

m-kuhn commented 1 week ago

@3nids review is done already

domi4484 commented 1 week ago

@domi4484 what happens if you add it more specific like here: https://github.com/kadas-albireo/kadas-albireo2/pull/112/files#diff-42a7083fe720c28474f5aa0dc9a4eef980b9a28cfc634300a3322b9d21fbdb49R133 ?

this works

kadas-albireo / kadas-albireo2

Add definition protected=public for bindings #115