search

kadas-albireo / kadas-albireo2

KADAS Albireo
GNU General Public License v2.0
66 stars 14 forks source link

Qca-qt5 and add includes #55

Closed domi4484 closed 5 months ago

domi4484 commented 5 months ago

@m-kuhn so it works for me. Question is if Qca-qt5 is very specific to my system and should we provide a FindQCA file similar to the QGIS one?

m-kuhn commented 5 months ago

Let's see if the build pipeline works well, if it does I would just use your package name (Qca-qt5) until we have a system where we need to do something more elaborate, when we can go to something like the following, possibly in a simple Find_Qca.cmake file

find_package(Qca)
if(NOT Qca_FOUND)
  find_package(Qca-qt5 REQUIRED)
endif()
m-kuhn commented 5 months ago

Let's see if the build pipeline works well, if it does I would just use your package name (Qca-qt5) until we have a system where we need to do something more elaborate, when we can go to something like the following, possibly in a simple Find_Qca.cmake file

find_package(Qca)
if(NOT Qca_FOUND)
  find_package(Qca-qt5 REQUIRED)
endif()

Actually... Just put it into an else() branch after if(WITH_VCPKG), it's not the cleanest solution, but we might well get through with that until we upgrade to Qt6 at some point in the future.