Update python packages - Githubissues

kadas-albireo / kadas-albireo2

KADAS Albireo

GNU General Public License v2.0

67 stars 14 forks source link

Update python packages #82

Closed bernspi closed 3 months ago

bernspi commented 4 months ago

Hi @3nids and @m-kuhn

I added some needed python libraries. For future work here, shall I commit to main directly or create a new branch like this one?

3nids commented 4 months ago

Creating a branch and opening the pull request is the right approach to collaborate, so we can review before integration.

There is a branch protection rule preventing from direct push to main (although admin can bypass this rule).

m-kuhn commented 3 months ago

Thanks @bernspi

Some first remarks:

we should ideally pin the versions (i.e. always us =={version_number}) to be stable with what we ship during testing / release
setuptools and packaging should already be installed through vcpkg, was there a specific reason to include these?

We currently have a problem on the build server (a recent software update broke something) As soon as this is back to live, we'll be able to continue with this.

bernspi commented 3 months ago

Ok, thanks for the clarification @m-kuhn

regarding =={versionnumber} , please add what suits you best
no specific reason, I just copy&pasted it from QGIS Installer for BV Release