Make libraries node *and web* compatible

alber70g commented 2 years ago

I think most packages will be used in both node and web environments. Therefore we need to make sure they are both web and node compatible.

Libraries like node-fetch can not be used in that case. As an alternative we could use cross-fetch

We also have to think of a way of assuring this is the case, with tests or otherwise.

[ ] add web-lib profile to heft-rig
[x] change node-fetch to node and web compatible lib
[x] buffer is not browser compatible https://github.com/kadena-community/kadena.js/blob/76f148cf69c356204620120c38b9a4d25125d829/packages/libs/cryptography-utils/src/hexToBin.ts#L7
[x] #77
[ ] Find out whether we can run our tests on headless chrome, next to node, so we don't have to have separate e2e tests

alber70g commented 2 years ago

One thing to do is to add a web-lib profile to the heft-rig that we have right now. Similar to @rushstack/heft-web-rig

github-actions[bot] commented 1 year ago

This issue is stale because it is open for 60 days with no activity

kadena-community / kadena.js