kadena-io / chainweaver

Kadena Chainweaver desktop wallet and web-based playground for Pact
https://chainweaver.kadena.network
60 stars 29 forks source link

gtransfer: dont sign every metadata change #765

Closed jmininger closed 2 years ago

jmininger commented 2 years ago

Currently GTransfer has two tabs: the Metadata and the Signing tab. When the user changes values in the metadata tab, they change the transfer's payload, which is represented as a Dynamic. We currently produce a new signature every time this dynamic changes. Signatures are an expensive operation (especially right now, in the browser), and this can result in frozen / glitched screens when the user attempts to change a value such as the gas-payer account. '

We only need to generate a transfer's signature after the payload is confirmed in the metadata tab and the user switches over to the signing / external signature tab. This PR addresses this.

mightybyte commented 2 years ago

This was included in #766