Stop exporting constructors for BlockHeader and PayloadData

kadena-io / chainweb-node

Chainweb: A Proof-of-Work Parallel-Chain Architecture for Massive Throughput

https://docs.kadena.io/basics/whitepapers/overview

BSD 3-Clause "New" or "Revised" License

248 stars 95 forks source link

Stop exporting constructors for BlockHeader and PayloadData #1862

Closed emmanueldenloye closed 5 months ago

emmanueldenloye commented 8 months ago

This PR refers to this asana ticket: https://app.asana.com/0/1204132908184958/1204876391903178/f

edmundnoble commented 8 months ago

This shows that BlockHeader's fields and constructor are used fairly extensively in tests. I'd be fine with just exporting them from a BlockHeader.Internal module instead, same with PayloadData.

chessai commented 5 months ago

closed in favour of #1977