Add Gas for Module loads - Githubissues

kadena-io / pact-5

The New Pact

BSD 3-Clause "New" or "Revised" License

8 stars 7 forks source link

Add Gas for Module loads #257

Closed jmcardon closed 3 weeks ago

jmcardon commented 3 weeks ago

This PR adds more accurate gassing for the operations of module load and dependency loads.

It also:

Fixes a longstanding inaccuracy of sizeOf
Removes generic SizeOf instances in favor of written ones. Our generic instances were a big culprit in bad estimation and making better ones without templateHaskell seems like a bigger pain. I would rather move to a templateHaskell solution later on.
Fixes a bug with legacy serialization
Fixes a bug with pretty printing of modrefs

PR checklist:

[x] Test coverage for the proposed changes
[x] PR description contains example output from repl interaction or a snippet from unit test output
[x] (If Relevant) Documentation has been (manually) updated at https://docs.kadena.io/pact

Additionally, please justify why you should or should not do the following:

[x] Benchmark regressions
[x] Confirm replay/back compat (Ignore until core release)
[x] (For Kadena engineers) Run integration-tests against a Chainweb built with this version of Pact (Ignore until core release)