Fix unexpected free variable in FV

rsoeldner commented 1 year ago

Addresses #1250

This PR makes use of a stack of free variables to allow for nested application of higher-order functions such as fold or map.

PR checklist:

[x] Test coverage for the proposed changes
[x] PR description contains example output from repl interaction or a snippet from unit test output
[x] Documentation has been updated if new natives or FV properties have been added. To generate new documentation, issue cabal run tests. If they pass locally, docs are generated.
[x] Any changes that could be relevant to users have been recorded in the changelog
[x] In case of changes to the Pact trace output (pact -t), make sure pact-lsp is in sync.

Additionally, please justify why you should or should not do the following:

[x] Confirm replay/back compat
[x] Benchmark regressions
[x] (For Kadena engineers) Run integration-tests against a Chainweb built with this version of Pact

jwiegley commented 1 year ago

@rsoeldner Where is the test to show what behavior this is actually impacting?

rsoeldner commented 1 year ago

@jwiegley ... missed pushing them

kadena-io / pact