kadena-io / pact

The Pact Smart Contract Language
https://docs.kadena.io/build/pact
BSD 3-Clause "New" or "Revised" License
579 stars 100 forks source link

Build docs for 4.7.1 #1289

Closed thomashoneyman closed 1 year ago

thomashoneyman commented 1 year ago

On a recent build of the docs directory — via the work.sh script — I noticed the build produces an update to the docs that include moving from Pact 4.7.0 to 4.7.1 and the addition of a disable runtime checking flag. Indeed, 4.7.1 is the latest release and the changelog specifies the addition of the new flag.

I also see that in the PR checklist there's a note that cabal run tests should update the docs, but doing so does not create any change in the docs, whereas running work.sh directly does. Is that out of date? Or is the docs update from work.sh unanticipated?


PR checklist:

Additionally, please justify why you should or should not do the following:

thomashoneyman commented 1 year ago

Oops — this probably ought to be closed, since I see 4.8 was released yesterday and I hadn't updated my fork yet. Still, I'm surprised not to see these 4.7.1 changes in already, or the 4.8.0 changes, so I'm curious about the proper way to generate docs between executing work.sh or using cabal run tests — whichever it is, it seems like the docs are not staying up-to-date with the master branch.

emilypi commented 1 year ago

Superseded by https://github.com/kadena-io/pact/pull/1288

I'm curious about the proper way to generate docs between executing work.sh or using cabal run tests — whichever it is, it seems like the docs are not staying up-to-date with the master branch.

There's a discrepancy here between RTD and what's generated via the tests: tests run the cabal macros that update version info and make any updates needed to the .md's for the RTD, but the docs/build.sh script generates the RTD .rsts from the .md's. So, there's two steps to fully generate docs:

  1. run cabal run hspec
  2. build the RTD's

The workflow is very manual, and we're working on migrating to an automatic release process so these things don't get dropped in the future.