kadena-io / pact

The Pact Smart Contract Language
https://pact-language.readthedocs.io/en/stable/
BSD 3-Clause "New" or "Revised" License
580 stars 100 forks source link

``(enforce-pact-version )`` doesn't work with two digits minor version #1327

Closed CryptoPascal31 closed 4 months ago

CryptoPascal31 commented 7 months ago

Issue description

When then minor version of Pact has 2 digits like currently, (enforce-pact-version ) doesn't parse it correctly

Steps to reproduce

Example 1:

pact> (pact-version)
"4.10"
pact> (enforce-pact-version "4.9")
<interactive>:0:0:Error: Invalid pact version 4.10, minimum allowed: 4.9
 at <interactive>:0:0: (enforce-pact-version "4.9")

Expected Behavior

(enforce-pact-version min-version) is supposed to accept versions higher or equal than min-version. I would expect the Example 1 to NOT throw an error

EDIT: Removed the second example

emilypi commented 6 months ago

Thanks @CryptoPascal31 - we'll get to this asap