[x] PR description contains example output from repl interaction or a snippet from unit test output
* [ ] Documentation has been updated if new natives or FV properties have been added. To generate new documentation, issue cabal run tests. If they pass locally, docs are generated.* [ ] Any changes that could be relevant to users have been recorded in the changelog* [ ] In case of changes to the Pact trace output (pact -t), make sure pact-lsp is in sync.
Additionally, please justify why you should or should not do the following:
[ ] Confirm replay/back compat
[ ] Benchmark regressions
[ ] (For Kadena engineers) Run integration-tests against a Chainweb built with this version of Pact
enforce-pact-version
was actually using lexicographic comparison due to the fact that the digit-parser is a stringy parser:The problem:
Which leads to the following case for the first time in Pact's history, now that it has a double-digit version part:
:tada:
This PR uses integer parsing on the version segments:
PR checklist:
* [ ] Documentation has been updated if new natives or FV properties have been added. To generate new documentation, issuecabal run tests
. If they pass locally, docs are generated.* [ ] Any changes that could be relevant to users have been recorded in the changelog* [ ] In case of changes to the Pact trace output (pact -t
), make sure pact-lsp is in sync.Additionally, please justify why you should or should not do the following: