This fixes replay. We check in evalCap if a cap's arguments have the right type.
We used to check in installSigCap too, which would be called before evalCap.
I recognized while implementing verifiers that this check was unnecessary and
deleted it, but we need it to remain, because otherwise the call stack from
the typechecking error changes and breaks replay.
PR checklist:
[ ] Test coverage for the proposed changes
[ ] PR description contains example output from repl interaction or a snippet from unit test output
[ ] Documentation has been updated if new natives or FV properties have been added. To generate new documentation, issue cabal run tests. If they pass locally, docs are generated.
This fixes replay. We check in
evalCapif a cap's arguments have the right type. We used to check ininstallSigCaptoo, which would be called beforeevalCap. I recognized while implementing verifiers that this check was unnecessary and deleted it, but we need it to remain, because otherwise the call stack from the typechecking error changes and breaks replay.PR checklist:
cabal run tests. If they pass locally, docs are generated.pact -t), make sure pact-lsp is in sync.Additionally, please justify why you should or should not do the following: