Update Links to Hyperlinks for Easy Access

kadenzipfel / smart-contract-vulnerabilities

A collection of smart contract vulnerabilities along with prevention methods

https://kadenzipfel.github.io/smart-contract-vulnerabilities/

1.83k stars 256 forks source link

Update Links to Hyperlinks for Easy Access #89

Closed rakesh0x7 closed 3 months ago

rakesh0x7 commented 3 months ago

Checklist

[X] I have searched the existing issues and pull requests for duplicates.

Type of Issue

[X] Update existing vulnerability

Description

Currently, the links in the source section of all the vulnerability pages on the Smart Contract Vulnerabilities website (https://kadenzipfel.github.io/smart-contract-vulnerabilities/vulnerabilities/) are not clickable hyperlinks. Users have to copy and paste the URLs manually, which can be inconvenient.

Proposed Solution:

Convert all plain text URLs in the source section to clickable hyperlinks. This will improve user experience by allowing users to click on the links directly.

rakesh0x7 commented 3 months ago

@kadenzipfel please let me know your thought on this, so that I will make a PR

0xSandyy commented 3 months ago

Hi @rakesh0x7, all the hyperlinks are available here: https://kadenzipfel.github.io/smart-contract-vulnerabilities/ or maybe i am missing something?

rakesh0x7 commented 3 months ago

Hi @rakesh0x7, all the hyperlinks are available here: https://kadenzipfel.github.io/smart-contract-vulnerabilities/ or maybe i am missing something?

I was referring to all plain text URLs in the source section.

these are not clickable hyperlinks. Users have to copy and paste the URLs manually, which can be inconvenient.

I wanted to convert all plain text URLs in the source section to clickable hyperlinks, which I already did for unencrypted-private-data-on-chain

0xSandyy commented 3 months ago

My bad. Good finding! Also I don't know how github.io hosting is working and how it is generating .html files but implementing a way to open link in a new tab after clicking would be even more convenient.

rakesh0x7 commented 3 months ago

@kadenzipfel, Unfortunately, there isn't a direct way to open links in a new tab using just Markdown within the mdBook. Can I at least go with opening links on the same page?