kadenzipfel / smart-contract-vulnerabilities

A collection of smart contract vulnerabilities along with prevention methods
https://kadenzipfel.github.io/smart-contract-vulnerabilities/
1.63k stars 218 forks source link

Add oracle price manipulation issue. #93

Open 0xSandyy opened 2 weeks ago

0xSandyy commented 2 weeks ago

Checklist

Type of Issue

Description

Oracles are widely used by smart contract to retrieve off-chain data. I would like to create an issue which focuses on how oracle price manipulation can occur(mainly flash loans) and some ways / best practices to mitigate the issue.

Additional Information

This issue might include a lot of DeFi terminologies like liquidity pools, flash loans, Amms, token price, etc. I would try to make this issue as simple as possible.

indeqs commented 2 weeks ago

While the proposed issue on oracle price manipulation via flash loans is undoubtedly important, it may not be well-suited for the repository due to its specialized nature within the DeFi ecosystem. The primary focus of the repository is on smart contract vulnerabilities, and the suggested topic requires a deeper understanding of DeFi-specific mechanisms, which might be outside the core knowledge base of the repository's intended audience.

Maybe a separate branch to focus on DeFi specific vulns. But come to think of it, does it mean that we also create another branch if we want to focus on vulns related to RWA's, Decentralized Insurance etc...

We should just focus on general smart contract issues IMO

0xSandyy commented 2 weeks ago

Exactly! That's why I created another issue regarding exactly that.

rakesh0x7 commented 2 weeks ago

@0xSandyy, could you please check issue #27? This issue was mentioned in that.

0xSandyy commented 2 weeks ago

Yeah, but 27 is an old one. Been waiting for @kadenzipfel reply on this issue.