Sobak
commented
9 months ago Even scrutinizer approves on his way out :joy:
Closed Sobak closed 9 months ago
Sobak
commented
9 months ago Even scrutinizer approves on his way out :joy:
Please also check questions which I posted as comments to this PR. I can do the final adjustments myself but I'll need confirmation for a few things.
Note: this PR bumps the minimal PHP version to 7.3, justification provided in https://github.com/kadet1090/KeyLighter/commit/a89e84d3f28d77784d9efc333d2eae16715a4074
On top of arguments stated there, I can add that 0.9 is gonna be the first version where we bump PHP requirement (I double-checked and the changelog entry is correct) so we can go higher without any issues and without bumping the minimal version on every single release.
Personally I would also drop PHP 7.3 and aim for PHP 7.4 as a minimal version but I didn't want to take this liberty yet since PHP 7.3 is enough to fix all the actual problems we're having right now.