search

kadikraman / draftjs-md-converter

Converts content from Draft.js blocks to Markdown and vice versa.
https://kadikraman.github.io/draftjs-md-converter/
MIT License
145 stars 37 forks source link

Critical dependency: the request of a dependency is an expression #57

Open josefalcon opened 4 years ago

josefalcon commented 4 years ago

Using version 1.4.0 in my app built with create-react-app. I see the following warning when building or running the development server:

Compiled with warnings.

./node_modules/draftjs-md-converter/dist/index.js
Critical dependency: the request of a dependency is an expression

Search for the keywords to learn more about each warning.
To ignore, add // eslint-disable-next-line to the line before.

It doesn't appear to break anything in my app, but would be nice to suppress this warning.

halileohalilei commented 4 years ago

I'm having this same problem, and our build system does not let us deploy with compilation warnings, so I can't use the latest version of this library. Downgrading to 1.3.0 seems to have worked for now.

arthureggert commented 4 years ago

@josefalcon to me this looks like a parcel problem

There is no way to remove this warning from this repo point of view.

kadikraman commented 4 years ago

I finally got around to building a small demo app for this library using create react app and was able to deploy it with no issues using draftjs-md-converter@^1.4.0 so I am unable to reproduce this issue.

Perhaps this has been resolved in latest versions of create react app? The demo app is using "react-scripts@3.4.1.

umarjavedse commented 3 years ago

@kadikraman That issue is still there please provide some solution for that.

kadikraman commented 3 years ago

Could you please provide steps to reproduce?

umarjavedse commented 3 years ago

@kadikraman Used latest version of this package even tried with old versions as but no gain.

kadikraman commented 3 years ago

Just released v1.5.0 which might have fixed this 🤞

chrisgbaker commented 3 years ago

Updating to the latest version seems to have fixed this issue 👍🏻