kadiks / react-native-itunes

iTunes module for React Native
MIT License
62 stars 39 forks source link

Cannot run on iOS 10.2 #4

Closed ospfranco closed 7 years ago

ospfranco commented 7 years ago

I added the library (first got a crash because you need to add permissions now), called getTracks and immediately got this:

img_5953

Any suggestions?

ospfranco commented 7 years ago

At first I thought this was fixed by the commit made by indesignlatam, but it seems it is not...

ospfranco commented 7 years ago

I have managed to get around this using this following code:

iTunes.getTracks({'fields': ['title']})
    .then((tracks) => {
      this.tracks = tracks;
    });

Seems validation on empty fields need to improve

kadiks commented 7 years ago

Perfect for the workaround.

I'll update the repo this week with the issue you talked about:

kadiks commented 7 years ago

I couldn't reproduce your bug, so if it's still there, I would need more details on the field that create that bug.

ospfranco commented 7 years ago

I have like 60 files with only title and artist name set, part of a ripped collection.

kadiks commented 7 years ago

Ok, I see. Is the new code fixes your issue?

ospfranco commented 7 years ago

Haven't tried it yet, new years celebration ;), I will try it on the weekend and let you know, thanks for the help!

ospfranco commented 7 years ago

It seems to be working perfectly now! many thanks!