search

kadirahq / blaze-layout

Layout Manager for Blaze (works well with Meteor FlowRouter)
MIT License
198 stars 62 forks source link

jQuery Dependency -- $ is not a function #43

Closed brunolemos closed 9 years ago

brunolemos commented 9 years ago

Blaze Layout seems to be dependent of jQuery public symbol $, but it's not adding it automatically. More specifically, the BlazeLayout.setRoot method.

If I remove the jquery package, this error appears: Exception in defer callback: TypeError: $ is not a function

I don't believe jquery needs to be a dependency so it would be nice to not use it! Or, if it must be used, it should be in the package dependencies to install it automatically, right?

Thanks :)

arunoda commented 9 years ago

You are correct. Let's see what we do about it.

arunoda commented 9 years ago

Released a new version with depending on jQuery. We need to jquery since we allow to pass CSS selectors in .setRoot(). Anyway, right now we need jQuery for blaze. So we need this.

brunolemos commented 9 years ago

Cool, thanks!