search

kadirahq / fast-render

Render you app even before the DDP connection is live. - magic?
MIT License
560 stars 80 forks source link

Mongodb dependency. Is it necessary? #96

Open neoromantic opened 9 years ago

neoromantic commented 9 years ago

Fast-render package depends on accounts-base, which uses mongo package.

As far as I understand this is used quite loose and can be abstracted.

Can it? My application does not use mongo at all (since it runs on low-resources ARM architecture) and it would be great to make fast-render more versatile.

arunoda commented 9 years ago

Fast render using accounts-base to authenticate users in the fast render scope. So, it's something we needed. On 2015 පෙබ 11, බදාදා at ප.ව. 6.39 Sergey Petrov notifications@github.com wrote:

Fast-render package depends on accounts-base, which uses mongo package.

As far as I understand this is used quite loose and can be abstracted.

Can it? My application does not use mongo at all (since it runs on low-resources ARM architecture) and it would be great to make fast-render more versatile.

— Reply to this email directly or view it on GitHub https://github.com/meteorhacks/fast-render/issues/96.

neoromantic commented 9 years ago

I see that, but it has already checks for Meteor.users collection availability and Accounts package availability right in its code. In case (like mine) when meteor accounts system is not used, fast-render could just ignore this context (i.e. run publication functions without userId in context). 

Basically, I’ve just forked fast-render into my local package, removed accounts-base dependency and it’s all working. 

Why not move it to weak dependencies?

On Feb 11, 2015, at 4:41 PM, Arunoda Susiripala notifications@github.com wrote:

Fast render using accounts-base to authenticate users in the fast render scope. So, it's something we needed. On 2015 පෙබ 11, බදාදා at ප.ව. 6.39 Sergey Petrov notifications@github.com wrote:

Fast-render package depends on accounts-base, which uses mongo package.

As far as I understand this is used quite loose and can be abstracted.

Can it? My application does not use mongo at all (since it runs on low-resources ARM architecture) and it would be great to make fast-render more versatile.

— Reply to this email directly or view it on GitHub https://github.com/meteorhacks/fast-render/issues/96.

— Reply to this email directly or view it on GitHub .

arunoda commented 9 years ago

Weak dependency idea is a goo thing. If you can work ok a PR, I am happy to accept. On 2015 පෙබ 11, බදාදා at ප.ව. 7.52 Sergey Petrov notifications@github.com wrote:

I see that, but it has already checks for Meteor.users collection availability and Accounts package availability right in its code. In case (like mine) when meteor accounts system is not used, fast-render could just ignore this context (i.e. run publication functions without userId in context).

Basically, I’ve just forked fast-render into my local package, removed accounts-base dependency and it’s all working.

Why not move it to weak dependencies?

On Feb 11, 2015, at 4:41 PM, Arunoda Susiripala < notifications@github.com> wrote:

Fast render using accounts-base to authenticate users in the fast render scope. So, it's something we needed. On 2015 පෙබ 11, බදාදා at ප.ව. 6.39 Sergey Petrov < notifications@github.com> wrote:

Fast-render package depends on accounts-base, which uses mongo package.

As far as I understand this is used quite loose and can be abstracted.

Can it? My application does not use mongo at all (since it runs on low-resources ARM architecture) and it would be great to make fast-render more versatile.

— Reply to this email directly or view it on GitHub https://github.com/meteorhacks/fast-render/issues/96.

— Reply to this email directly or view it on GitHub .

— Reply to this email directly or view it on GitHub https://github.com/meteorhacks/fast-render/issues/96#issuecomment-73888228 .

neoromantic commented 9 years ago

Great, will do soon. Thanks.

On Feb 11, 2015, at 5:25 PM, Arunoda Susiripala notifications@github.com wrote:

Weak dependency idea is a goo thing. If you can work ok a PR, I am happy to accept. On 2015 පෙබ 11, බදාදා at ප.ව. 7.52 Sergey Petrov notifications@github.com wrote:

I see that, but it has already checks for Meteor.users collection availability and Accounts package availability right in its code. In case (like mine) when meteor accounts system is not used, fast-render could just ignore this context (i.e. run publication functions without userId in context).

Basically, I’ve just forked fast-render into my local package, removed accounts-base dependency and it’s all working.

Why not move it to weak dependencies?

On Feb 11, 2015, at 4:41 PM, Arunoda Susiripala < notifications@github.com> wrote:

Fast render using accounts-base to authenticate users in the fast render scope. So, it's something we needed. On 2015 පෙබ 11, බදාදා at ප.ව. 6.39 Sergey Petrov < notifications@github.com> wrote:

Fast-render package depends on accounts-base, which uses mongo package.

As far as I understand this is used quite loose and can be abstracted.

Can it? My application does not use mongo at all (since it runs on low-resources ARM architecture) and it would be great to make fast-render more versatile.

— Reply to this email directly or view it on GitHub https://github.com/meteorhacks/fast-render/issues/96.

— Reply to this email directly or view it on GitHub .

— Reply to this email directly or view it on GitHub https://github.com/meteorhacks/fast-render/issues/96#issuecomment-73888228 .

— Reply to this email directly or view it on GitHub .

julian-rare commented 7 years ago

Any news on this? I'm working on a mongoless meteor app with ssr, but found mongo to be a major pain