No fine-grained reactivity on parameters in grouped route prefixes

[rclai]

If grouped route uses a param in the prefix, changing to a different route in the same group should not trigger invalidation on that param again.

var group = FlowRouter.group({
  prefix: '/group/:_id'
});

group.route('/a', {
  name: 'a'
});

group.route('/b', {
  name: 'b'
});

Tracker.autorun(function (c) {
  console.log('_id:', FlowRouter.getParam('_id'));
});

var id = 'test';
FlowRouter.go('a', { _id: id });
FlowRouter.go('b', { _id: id });

[arunoda]

I didn't check this but following code seems pretty wrong to me.

Tracker.autorun(function (c) {
  if (! c.firstRun) {
    console.log('_id:', FlowRouter.getParam('_id'));
  }
});

So, in the firstRun it won't see getParam(). So, there won't be any re-runs. Try to put it before if.

[rclai]

Oh, right. I just did that just so you didn't see it be undefined on the first run, but I guess you understand.

[arunoda]

I'll have look at this.

[rclai]

Thanks.

[arunoda]

@delgermurun did we support params in the prefix?

[rclai]

It does work, thanks to this. There's no tests for it though.

[arunoda]

Ah! Now I got it. Oh! didn't read the title at all. Sounds like a good call. Let's see what's going on here.

[rclai]

I think I made the title too long haha.

[arunoda]

We need TLDR for titles as well :P

[rclai]

Okay, this title is better :smile:.

[arunoda]

ha ha :D

[arunoda]

@rclai This involves a lot of things than it seems. This involves major refactor. So, I'm deferring this for 3.0 I hope that's okay.

[rclai]

I figured it would, no problem.