search

kadirahq / flow-router

Carefully Designed Client Side Router for Meteor
MIT License
1.09k stars 194 forks source link

Upgrade to Meteor 1.3 beta 5 throws error for FlowRouter-SSR #505

Closed jasongrishkoff closed 8 years ago

jasongrishkoff commented 8 years ago

Getting this error after upgrading to beta 5. Using the latest version of FlowRouter-ssr (3.9.0)

packages/kadira:flow-router-ssr/lib/router.js:43:8: /packages/kadira:flow-router-ssr/lib/router.js: Duplicate declaration "path"

Rolling back to beta 4 solved the issue.

SylarRuby commented 8 years ago

Clearly the issue is not resolved. Rolling back only avoided the issue.

arunoda commented 8 years ago

Here's the line: https://github.com/kadirahq/flow-router/blob/ssr/lib/router.js#L43 And clearly there is no issue.

I wonder what's the issue here. Could you guys add an issue on meteor repo for this?

PEM-- commented 8 years ago

I've referenced the issue: https://github.com/meteor/meteor/issues/6138

PEM-- commented 8 years ago

In the meantime, I've created a small PR: https://github.com/kadirahq/flow-router/pull/515

arunoda commented 8 years ago

This is fixed in version v3.9.1.

PEM-- commented 8 years ago

Thanks :+1: