search

kadirahq / flow-router

Carefully Designed Client Side Router for Meteor
MIT License
1.09k stars 194 forks source link

redirect broken with meteor beta 11 #539

Closed timothyarmes closed 8 years ago

timothyarmes commented 8 years ago

Hi,

Using the latest versions of flow-router-ssr and meteor beta 11 my app now crashes when I try to redirect from inside a trigger.

Tracing the code, the bug appears to be a Babel issue. I've reported it here:

https://github.com/meteor/meteor/issues/6312

I'm also opening an issue here so that it can be tracked.

arunoda commented 8 years ago

Thanks.

arunoda commented 8 years ago

Seems like this will be fixed in beta-12.

dufia commented 8 years ago

Hey @arunoda

Is redirecting broken? I use beta-12 and I get:

Uncaught TypeError: str.slice is not a function
while ((res = PATH_REGEXP.exec(str)) != null) {
    var m = res[0]
    var escaped = res[1]
    var offset = res.index
    path += str.slice(index, offset)
    index = offset + m.length

Thanks

dufia commented 8 years ago

@timothyarmes It seems to be fixed in release/METEOR@1.3-rc.8 that came out two days ago

timothyarmes commented 8 years ago

Yes, was fixed in rc1- I'll close this.