client.browserify issue with meteor 1.3 beta.16

[danielbh]

I was trying to add flowrouter to the new beta 16 that just came out: https://github.com/meteor/meteor/releases/tag/release%2FMETEOR%401.3-beta.16

I received the following error just for installing the package and without any coding whatsoever...

=> Errors prevented startup:

While processing files with cosmos:browserify (for target web.browser): packages/kadira:flow-router/client.browserify.js: Arguments to path.resolve must be strings

Browserify options:

undefined

I have no idea what is causing this. I looked at: https://github.com/kadirahq/flow-router/blob/master/client.browserify.js

and I don't see any issue with it. What are your thoughts? Thanks.

[suhail-ansari-apconic]

There is already an issue created on meteor git repository and here is answer from benjamin. Basically flowrouter has to remove dependency from browserify and use modules.

https://github.com/meteor/meteor/issues/6449

[mcbain]

+1

[huttonr]

:+1:

[suhail-ansari-apconic]

Are we going to see this fixed any time soon. I already see a PR related to this. Beta 16 solves a lot of issues we were facing due to node defaults being not available but cannot use it because of this problem.

[patrickml]

:+1:

[patrickml]

UPDATE : issue still persists on 1.3-rc.1

[arunoda]

For what ever the reason, I can't publish a new version to some dependency issues. I assume, that's because of we are using a RC version. I think meteor packaging system has some special meaning for tagged releases like above.

So, I suggest you to use this branch directly. See: use-meteor-modules-support

I'll publish a new version, when Meteor 1.3 released. (I hope it'll happen soon)

[sgasser]

@arunoda thx How we can use this branch directly?

[suhail-ansari-apconic]

Just clone or download this branch code to your local packages folder until kadira fixes it. By the way the release date for meteor is March 21.

[richard-edwards]

I created a packages folder under my application root and cd' to the packages folder, cloned the repo and ran meteor run and same error for me. Meteor newb here so maybe I'm misunderstanding what to do. The module I'm using is kadira:flow-router-ssr, and the package I cloned that was created in packages was flow-router, does that have any bearing?

[suhail-ansari-apconic]

Just remove kadirahq:flow-router-ssr from your packages. Clone this repo with this branch to your packages then run

[tmeasday]

@arunoda can we figure out what the problem with publishing is? It'd be super useful to get this out before 1.3 to ensure there aren't any issues with 1.3 we need to fix!

[macrozone]

Same issue as @redwards1966, I did also clone the repo in my packages folder, checked out use-meteor-modules-support and still got the same error.

What i found out is, that if you downgrade meteor, run it and upgrade again, the error no longer occures until you do a meteor reset or similar.

Update: my error is not ecaclty the same, it is:

While processing files with cosmos:browserify (for target web.browser):
   packages/react-runtime-dev/react.browserify.js: Arguments to path.resolve must be strings

   Browserify options:
   >  undefined

Strange, this file ' packages/react-runtime-dev/react.browserify.js' seems not to exist on my machine...

[patrickml]

Is there anyway you can just create an Npm package? On Wed, Mar 16, 2016 at 6:08 PM Marco Wettstein notifications@github.com wrote:

Same issue as @redwards1966 https://github.com/redwards1966, I did also clone the repo in my packages folder, checked out use-meteor-modules-support and still got the same error.

What i found out is, that if you downgrade meteor, run it and upgrade again, the error no longer occures until you do a meteor reset or similar.

— You are receiving this because you commented. Reply to this email directly or view it on GitHub https://github.com/kadirahq/flow-router/issues/552#issuecomment-197574789

[arunoda]

Okay. I managed to publish a version of Flow Router SSR to the packaging server. Use this version: v3.12.1

This version has some minor test failures. (comes with porting to RC). I'll fix them in coming days. But I publish this because otherwise, it's hard to test the RC.

[tmeasday]

Thanks so much @arunoda!

On Thu, 17 Mar 2016 at 09:47 Arunoda Susiripala notifications@github.com wrote:

Okay. I managed to publish a version of Flow Router SSR to the packaging server. Use this version: v3.12.1

This version has some minor test failures. (comes with porting to RC). I'll fix them in coming days. But I publish this because otherwise, it's hard to test the RC.

— You are receiving this because you commented. Reply to this email directly or view it on GitHub https://github.com/kadirahq/flow-router/issues/552#issuecomment-197591064

[arunoda]

@tmeasday I had to use meteor publish --release METEOR@1.3-rc.1.

So, if there's a new RC, do I need to publish again?

[tmeasday]

@arunoda, nope. You just need to use --release when publishing packages that use features from new releases.

[arunoda]

@tmeasday That's great. So, METEOR@1.3-rc.1 comes out, it'll work properly.

[tmeasday]

@arunoda and what about a version of flow-router vanilla?

[arunoda]

Yeah. I can do that too. Will do it, I think that'll be pretty useful.

[merlinstardust]

That would be much appreciated! I was just about to start using Mantra, but since Mantra relies on on flow-router, I can't get my project started

[arunoda]

@merlinpatt just checkout the sample repo again. I've updated to use this version.

[merlinstardust]

I'm using the mantra-cli to create my starting repo, which uses the vanilla kadira:flow-router package in the create command.

[arunoda]

@tmeasday @merlinpatt done. try updating the vanilla FlowRouter.

[merlinstardust]

Thanks @arunoda. You're amazing with your super quick fixes!

[tmeasday]

Awesome: https://github.com/meteor/todos/commit/91fce29f3aec56caab921216cf2e227512ca1ef9

[arunoda]

We fixed some issues we had with Meteor 1.3 RC-1 and now you can use the SSR version with the confidence :) Thanks all for the help.

[Dev1an]

@suhail-ansari-apconic How do you now the meteor 1.3 release date?