search

kadirahq / flow-router

Carefully Designed Client Side Router for Meteor
MIT License
1.09k stars 195 forks source link

[2.12.0] Problem in router.js: Uncaught ReferenceError: page is not defined #602

Closed juliancwirko closed 8 years ago

juliancwirko commented 8 years ago

Hi, there is a problem in 2.12.0 In router.js, I get:

Uncaught ReferenceError: page is not defined
cormip commented 8 years ago

Also started getting the same problem after upgrading from 2.11.0 to 2.12.0. This happened in parallel to an update from Meteor 1.3.1 to 1.3.2.4 as well as a bunch of packages. So, just to be sure, I ONLY downgraded kadira:flow-router to 2.11.0 leaving all the other updates in place and the error disappeared.

BTW, my app doesn't work at all when this error is thrown.

halvardos commented 8 years ago

This line:

- api.addFiles('client-modules.js', 'client');

In this commit seems to be what is causing the problem.

mikeifomin commented 8 years ago

I have the same error. Meteor 1.3.2.4

versions

kadira:flow-router@2.12.0
meteorhacks:fast-render@2.14.0
agentirons commented 8 years ago

Yep, same error from upgrading to Meteor 1.3.2.4 and Flow-Router 2.12.0 -

router.js:586 Uncaught ReferenceError: page is not defined

586 Router.prototype._page = page;

mikeifomin commented 8 years ago

Downgrade to kadira:flow-router @2.11.0 helped!

LukeGallant commented 8 years ago

Also getting this issue

spiral2k commented 8 years ago

@mikeifomin it didnt helped :(

spiral2k commented 8 years ago

Does anybody has a solution for this problem,?

yubozhao commented 8 years ago

@spiral2k with downgrade, it works for me. Good luck on your app

michaeljberry commented 8 years ago

Removing the 2.12.0 version and adding the 2.11.0 version worked for me.

meteor add kadira:flow-router@=2.11.0

spiral2k commented 8 years ago

@yubozhao @michaeljberry thanks a lot!.

LukeGallant commented 8 years ago

Version downgrade also worked for me

arunoda commented 8 years ago

Sorry about the issue. Will be working on a quick fix.

arunoda commented 8 years ago

Check version: v2.12.1. It has a fix for this.

agentirons commented 8 years ago

Works great, thanks!

ujwal-setlur commented 8 years ago

thanks, that works. thanks for the quick fix.

arunoda commented 8 years ago

Okay. Cool.

anormore commented 7 years ago

Just wanted to let you know that I did an meteor add kadira:flow-router and followed the doc.

Doesn't work. Found this thread on Google.

I had to put kadira:flow-router@2.11.0 in my packages list and it works.

I'm replacing Iron Router.