kadirahq / meteor-dochead

Isomorphic way to manipulate document.head for Meteor apps
MIT License
132 stars 17 forks source link

Build error on Meteor 1.2.0.2 #12

Closed JeremySaks closed 8 years ago

JeremySaks commented 8 years ago

Trying to run meteor on the new version 1.2.0.2 with kadira:dochead@1.2.0 results in the following:

=> Started proxy.
=> Started MongoDB.
=> Errors prevented startup:

   While processing files with cosmos:browserify (for target web.browser):
   packages/kadira:dochead/package.browserify.js: Arguments to path.resolve must be strings

   While processing files with cosmos:browserify (for target web.cordova):
   packages/kadira:dochead/package.browserify.js: Arguments to path.resolve must be strings

=> Your application has errors. Waiting for file change.
kokjinsam commented 8 years ago

+1

krstffr commented 8 years ago

+1

TimFletcher commented 8 years ago

I believe this is a duplicate of #11.

I'm having the same issue which I resolved by editing my meteor/.versions file to move back to version 1.1.0.

arunoda commented 8 years ago

I got this issue too and disappear somehow. Not sure why. Anyway, I updated the browserify version and published a new version. (1.2.1)

If you got this again, may be you can remove .meteor/local directory and try again.

Hope all you guys are using Meteor 1.2

krstffr commented 8 years ago

@arunoda sorry, removing .meteor/local does not fix it.

Still getting:

While processing files with cosmos:browserify (for target web.browser):
   packages/kadira:dochead/package.browserify.js: Arguments to path.resolve must be strings
arunoda commented 8 years ago

Okay. Let me get some help from a help from a specialist.

krstffr commented 8 years ago

@arunoda you guys are the best! :+1:

elidoran commented 8 years ago

This error is, unfortunately, my fault. Please update to cosmos:browserify 0.8.0. Versions 0.7.1 through 0.7.4 are broken. They are attempts to make it work properly for all the variations there are, and, it fails to do so.

The new Build API of Meteor 1.2 is wreaking havoc on my plugin because it no longer provides actual directory location information, and, it builds the packages in more places. packages are now published in an unbuilt format and require building by a plugin from their location in ~/.meteor/packages, which also puts the npm modules into npm instead of .npm/package.

Essentially, this, fairly simple two steps, has become this, deep property inspection.

Any recommendations for improving it are appreciated.

JeremySaks commented 8 years ago

meteor update cosmos:browserify and re-adding dochead does the trick!

arunoda commented 8 years ago

Thanks @elidoran I'll update it. Not sure any recommendations.

arunoda commented 8 years ago

I published the new version. Hopefully it should fix this issue.

TimFletcher commented 8 years ago

Seems good for me. Thanks!

bmanturner commented 8 years ago

Not fixed on Windows 7

While processing files with cosmos:browserify (for target web.browser): packages/kadira:dochead/package.browserify.js: Cannot find module 'load-script' from '\C\Users\bmanturner\AppData\Local.meteor\packages\kadira_dochead\1.2.2\npm'

Note: The directory of the application is located in C\Users\bmanturner\Documents, not AppData.

elidoran commented 8 years ago

The kadira:dochead package is stored in AppData when you add it to an app via meteor add kadira:dochead.

I see a possible cause. It looks like I need to do Plugin.convertToOSPath() to convert the property from the *nix style path (used internally everywhere by Meteor) to the windows style path. I'll patch it later today.