kadirahq / meteor-dochead

Isomorphic way to manipulate document.head for Meteor apps
MIT License
132 stars 17 forks source link

client.browserify issue with meteor 1.3 beta.16 and above #30

Open cstrat opened 8 years ago

cstrat commented 8 years ago

https://github.com/kadirahq/flow-router/issues/552 ^ Same issue as experienced here.

=> Started proxy.                             
=> Started MongoDB.                           
=> Errors prevented startup:                  

While processing files with cosmos:browserify (for target web.browser):
packages/kadira:flow-router/client.browserify.js: Arguments to path.resolve must be strings

Browserify options:
>  undefined
packages/kadira:dochead/package.browserify.js: Arguments to path.resolve must be strings

Browserify options:
>  undefined
kokjinsam commented 8 years ago

I wonder if it's the same issue. I got this error instead:

=> Errors prevented startup:                  

   While processing files with cosmos:browserify (for target web.browser):
   packages/kadira:dochead/package.browserify.js: Cannot find module 'load-script' from
   '/home/skaxwng/code/clean-mantra-webpack'

=> Your application has errors. Waiting for file change.
arunoda commented 8 years ago

We need to remove the browserify package. We did it with the FlowRouter. Will do a fix soon.

cstrat commented 8 years ago

Is any sort of hot fix for the time being?

arunoda commented 8 years ago

For now, you have to remove browserify manually from this project and remove this file: https://github.com/kadirahq/meteor-dochead/blob/master/package.browserify.js

JeremySaks commented 8 years ago

Just a note after upgrading to 1.3 with dochead still included and unaltered, Meteor now starts with the message:

Unable to resolve some modules:

  "load-script" in /Users/jeremysaks/.meteor/packages/kadira_dochead/.1.4.0.1gp2m0m++os+web.browser+web.cordova/web.browser/package.browserify.js
(web.browser)

Consider running: meteor npm install --save load-script

The startup completes and the meta tags are correctly set, so I'm wondering if the advice is still to manually patch the package. Any reason not to leave it alone until a fix is released?

arunoda commented 8 years ago

Merged #32 and this should be fixed by now properly.