search

kadirahq / meteord

MeteorD - Docker Runtime for Meteor Apps for Production Deployments
https://registry.hub.docker.com/u/meteorhacks/meteord/
MIT License
89 stars 43 forks source link

Build failing #9

Open macsj200 opened 8 years ago

macsj200 commented 8 years ago

Currently, CI says the latest build version is failing, what's up with that?

gkrizek commented 8 years ago

It's failing because the Meteor update to 1.4 broke the original Meteord, which this is forked from. It hasn't really been touched since the fork of the old version.

Is there a timeline for when this will be usable with 1.4?

macsj200 commented 8 years ago

If someone can give me some suggestions for the fix I can try my hand at a PR, but I'm a bit of a docker n00b and I could use some help digging around.

gkrizek commented 8 years ago

Well the obvious change was updating Node, which has already been done. (See this commit)

From there I think it's just a matter of trying to build it and running through the errors. Someone else might have a more precise idea of what needs fixing, though. There are also 2 outstanding PRs right now that seem to be necessary updates.

mwarren2 commented 8 years ago

@macsj200 I assume that it's not working because the pull request that fixed the code failed, if the big red FAILED sign on the main page is anything to go by, though to be honest I'm not exactly sure what the failed sign means.

To get around the problem, and so that I could use Meteor 1.4, I cloned the current meteorhacks:meteord code to my machine git clone https://github.com/meteorhacks/meteord.git

and manually made the three changes from this page [https://github.com/meteorhacks/meteord/pull/108/files] in the copy on my machine.

I then got docker-compose to build from my local copy, and it works, perfectly.

Of course I would prefer for it to be fixed permanently, and use the dockerfile directly from here. Because it looks as if they're going to leave meteorhacks:meteord at 1.3, and have kadirahq:meteord here running 1.4.